Split setgid and setuid, add privilege check [RFC] #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
suggested changes
Sep 20, 2016
| @@ -156,10 +156,18 @@ int main(int argc, char **argv) { | |||
| exit(EXIT_FAILURE); | |||
| } | |||
| if (getuid() != geteuid() || getgid() != getegid()) { | |||
| if (setgid(getgid()) != 0 || setuid(getuid()) != 0) { | |||
| if (setgid(getgid()) != 0){ | |||
There was a problem hiding this comment.
Style error here, space between ) and {
This commit deals with issue swaywm#884. I consulted the following sources: https://www.securecoding.cert.org/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges and https://www.securecoding.cert.org/confluence/display/c/POS37-C.+Ensure+that+privilege+relinquishment+is+successful
thejan2009
force-pushed
the
setgid-setuid
branch
from
aa38bbd
to
5e585f9
Compare
ddevault
approved these changes
Sep 27, 2016
This was referenced Sep 28, 2016
This was referenced Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deals with issue #884. I consulted the following sources:
https://www.securecoding.cert.org/confluence/display/c/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges
and
https://www.securecoding.cert.org/confluence/display/c/POS37-C.+Ensure+that+privilege+relinquishment+is+successful